[webkit-reviews] review granted: [Bug 117758] Make it possible to set a minimum height for auto-layout : [Attachment 204946] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 18 14:54:33 PDT 2013


Tim Horton <thorton at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 117758: Make it possible to set a minimum height for auto-layout
https://bugs.webkit.org/show_bug.cgi?id=117758

Attachment 204946: Patch
https://bugs.webkit.org/attachment.cgi?id=204946&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204946&action=review


> Source/WebKit2/ChangeLog:50
> +	   * Shared/WebPageCreationParameters.cpp:
> +	   (WebKit::WebPageCreationParameters::encode):
> +	   (WebKit::WebPageCreationParameters::decode):
> +	   * Shared/WebPageCreationParameters.h:
> +	   * UIProcess/API/mac/WKView.mm:
> +	   (-[WKView _setIntrinsicContentSize:]):
> +	   (-[WKView minimumLayoutWidth]):
> +	   (-[WKView setMinimumLayoutWidth:]):
> +	   (-[WKView minimumWidthForAutoLayout]):
> +	   (-[WKView setMinimumWidthForAutoLayout:]):
> +	   (-[WKView minimumSizeForAutoLayout]):
> +	   (-[WKView setMinimumSizeForAutoLayout:]):
> +	   * UIProcess/API/mac/WKViewPrivate.h:
> +	   * UIProcess/DrawingAreaProxy.h:
> +	   (WebKit::DrawingAreaProxy::minimumLayoutSizeDidChange):
> +	   * UIProcess/WebPageProxy.cpp:
> +	   (WebKit::WebPageProxy::WebPageProxy):
> +	   (WebKit::WebPageProxy::creationParameters):
> +	   (WebKit::WebPageProxy::setMinimumLayoutSize):
> +	   * UIProcess/WebPageProxy.h:
> +	   (WebKit::WebPageProxy::minimumLayoutSize):
> +	   * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
> +	   * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
> +	  
(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy
):
> +	  
(WebKit::TiledCoreAnimationDrawingAreaProxy::minimumLayoutSizeDidChange):
> +	   (WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
> +	  
(WebKit::TiledCoreAnimationDrawingAreaProxy::intrinsicContentSizeDidChange):
> +	   (WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
> +	   * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
> +	   (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
> +	   * WebProcess/WebPage/WebPage.cpp:
> +	   (WebKit::WebPage::WebPage):
> +	   (WebKit::WebPage::setMinimumLayoutSize):
> +	   * WebProcess/WebPage/WebPage.h:
> +	   (WebKit::WebPage::minimumLayoutSize):
> +	   * WebProcess/WebPage/WebPage.messages.in:
> +	   * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
> +	  
(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
> +	   (WebKit::TiledCoreAnimationDrawingArea::updateGeometry):

Yikes.


More information about the webkit-reviews mailing list