[webkit-reviews] review granted: [Bug 117754] widthMediaFeatureEval ends up with null FrameView during iframe unload. : [Attachment 204943] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 18 14:42:41 PDT 2013


Geoffrey Garen <ggaren at apple.com> has granted Zalan Bujtas <zalan at apple.com>'s
request for review:
Bug 117754: widthMediaFeatureEval ends up with null FrameView during iframe
unload.
https://bugs.webkit.org/show_bug.cgi?id=117754

Attachment 204943: Patch
https://bugs.webkit.org/attachment.cgi?id=204943&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204943&action=review


r=me

>
LayoutTests/fast/frames/crash-when-child-iframe-forces-layout-during-unload-and
-sibling-frame-has-mediaquery.html:20
> +<div id='resizeThis'>Ensures that when layout is forced on unload event,
frames with media query do not crash.</div>

Should be "...during an unload event.." and "...frames with media queries..."


More information about the webkit-reviews mailing list