[webkit-reviews] review denied: [Bug 117667] Expose a getMediaType method in WebKit : [Attachment 204869] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Ruth Fong <ruthiecftg at gmail.com>'s
request for review:
Bug 117667: Expose a getMediaType method in WebKit
https://bugs.webkit.org/show_bug.cgi?id=117667

Attachment 204869: Patch
https://bugs.webkit.org/attachment.cgi?id=204869&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204869&action=review


> Source/WebKit2/UIProcess/API/C/WKAPICast.h:176
> +    
> +    return kWKBundleHitTestResultMediaTypeNone;

ASSERT_NOT_REACHED() here also, right?

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:32
> +#include <WebKit2/InjectedBundleHitTestResultMediaType.h>
> +#include <WebKit2/WKBundleHitTestResult.h>

These headers are local to the WK2 project, so it should just be #include
"InjectedBundleHitTestResultMediaType.h" under the APIObject include.

And the WKBundleHitTestResult.h include isn't needed at all - that's what we're
avoiding with all these casts and such!

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:84
> +    return toImpl(hitTestResultRef)->getMediaType();

This needs to be:
return toAPI(toImpl(hitTestResultRef)->getMediaType()) to perform the
InjectedBundle* -> WKBundle* cast