[webkit-reviews] review granted: [Bug 117728] [EFL][WK2] Implement unit test callback: onSettingChange : [Attachment 204920] apply suggestions

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has granted Krzysztof Wolanski
<k.wolanski at samsung.com>'s request for review:
Bug 117728: [EFL][WK2] Implement unit test callback: onSettingChange
https://bugs.webkit.org/show_bug.cgi?id=117728

Attachment 204920: apply suggestions
https://bugs.webkit.org/attachment.cgi?id=204920&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204920&action=review


LGTM. r=me with nits. Please let Grzegorz have a look before landing.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:228
> +static Ewk_Context_Menu_Item* findContextMenuItem(Ewk_Context_Menu*
contextMenu, const Ewk_Context_Menu_Item_Action& itemAction, const
Ewk_Context_Menu_Item_Type& itemType)

nit: contextMenu could be a const pointer, and it is overkill to pass enum
types by const reference.