[webkit-reviews] review granted: [Bug 117695] [WinCairo] Webfont rendering is broken. : [Attachment 204915] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 18 09:17:11 PDT 2013
Brent Fulgham <bfulgham at webkit.org> has granted peavo at outlook.com's request for
review:
Bug 117695: [WinCairo] Webfont rendering is broken.
https://bugs.webkit.org/show_bug.cgi?id=117695
Attachment 204915: Patch
https://bugs.webkit.org/attachment.cgi?id=204915&action=review
------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204915&action=review
This patch looks great. Could you just make the "#elif" change I asked for
when you land the change?
> Source/WebCore/platform/graphics/FontPlatformData.h:107
> #if USE(CAIRO)
nit: This should probably have been an "#elif USE(CAIRO)", since we never use
both graphics packages together (they are exclusive).
More information about the webkit-reviews
mailing list