[webkit-reviews] review denied: [Bug 106620] [EFL] Add support for MHTML save/load feature to MiniBrowser : [Attachment 204908] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has denied Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 106620: [EFL] Add support for MHTML save/load feature to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=106620

Attachment 204908: Patch
https://bugs.webkit.org/attachment.cgi?id=204908&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204908&action=review


> Tools/MiniBrowser/efl/main.c:441
> +	   char *save_file_name = show_file_entry_dialog(window);

you need to eina_stringshare_del() after use.

> Tools/MiniBrowser/efl/main.c:979
> +static char*

should return a Eina_Stringshare *

> Tools/MiniBrowser/efl/main.c:1022
> +    const char *file_path = ok ?
eina_stringshare_add(elm_fileselector_entry_path_get(fs_entry)) : NULL;

should use eina_stringshare_ref() not eina_stringshare_add() as this is already
a stringshare according to the doc.