[webkit-reviews] review granted: [Bug 116647] Clean the global crash hook handling : [Attachment 202640] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 116647: Clean the global crash hook handling
https://bugs.webkit.org/show_bug.cgi?id=116647

Attachment 202640: Patch
https://bugs.webkit.org/attachment.cgi?id=202640&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202640&action=review


Looks good, but you'll need to land it manually.

> Source/JavaScriptCore/ChangeLog:9
> +	   *
JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.
in:

We no longer use these!

>
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExport
s.def:-570
> -    WTFSetCrashHook

These files are gone now...

>
Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/Java
ScriptCoreExports.def.in:-569
> -    WTFSetCrashHook

Ditto...