[webkit-reviews] review denied: [Bug 117667] Expose a getMediaType method in WebKit : [Attachment 204860] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Ruth Fong <ruthiecftg at gmail.com>'s
request for review:
Bug 117667: Expose a getMediaType method in WebKit
https://bugs.webkit.org/show_bug.cgi?id=117667

Attachment 204860: Patch
https://bugs.webkit.org/attachment.cgi?id=204860&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204860&action=review


> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:111
> +    if (node->nodeType() != Node::ELEMENT_NODE)
> +	   return kWKBundleHitTestResultMediaTypeNone;

This should probably be if (node->isElementNode()) instead.  Sorry for not
catching that earlier.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:32
>  #include <WebCore/HitTestResult.h>
> +#include <WebKit2/WKBundleHitTestResult.h>
>  #include <wtf/Forward.h>

Seeing this in the flesh set off a red flag - We shouldn't be directly
including API headers in implementation files when we can avoid it.

I've suggested to Ruth on IRC a path forward with an API set of enums, an impl
set of enums, and API casting.