[webkit-reviews] review granted: [Bug 117648] coverage data to json script : [Attachment 204726] Patch

[bugzilla-daemon at webkit.org]

Stephanie Lewis <slewis at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 117648: coverage data to json script
https://bugs.webkit.org/show_bug.cgi?id=117648

Attachment 204726: Patch
https://bugs.webkit.org/attachment.cgi?id=204726&action=review

------- Additional Comments from Stephanie Lewis <slewis at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204726&action=review


A few minor comments, otherwise it looks good. Clean up the style a little and
then r=me

> Tools/ChangeLog:7
> +

You should add a blurb about what the project is and what piece this is

> Tools/Scripts/generate-coverage-data:71
> +

spaces between concatenation operators

Usually add an error message after die.

i.e.
or die "Cannot open $file";

> Tools/Scripts/generate-coverage-data:73
> +open my $jsonFile, ">", "WebKitBuild/Coverage/".$resultName.".json" or die
"error opening json file";

spaces

> Tools/Scripts/generate-coverage-data:74
> +print $jsonFile
encode_json(parseGcovrOutput("WebKitBuild/Coverage/".$resultName.".xml"));

spaces

> Tools/Scripts/generate-coverage-data:89
> +    foreach my $packageName (keys %$packages) {

nit, I think this is usually written %{$packages}

> Tools/Scripts/generate-coverage-data:92
> +	   # Perl's XML::Simple causes files to be here if there's only one
child even though they're a layer deeper in the xml tree

Files to be where?  This comment confused me.

> Tools/Scripts/generate-coverage-data:153
> +	   $line->{"condition-coverage"} =~ /\((.*)\/(.*)\)/;

should add a comment saying what this regex is looking for.

> Tools/Scripts/generate-coverage-data:156
> +	   push(@$branchLines,int($line->{"number"}));

spaces between parameters