[webkit-reviews] review granted: [Bug 117663] [CSS Shapes] Consider bottom borders when calculating the position of the overflow : [Attachment 204750] proposed patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 117663: [CSS Shapes] Consider bottom borders when calculating the position
of the overflow
https://bugs.webkit.org/show_bug.cgi?id=117663

Attachment 204750: proposed patch
https://bugs.webkit.org/attachment.cgi?id=204750&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204750&action=review


Looks good.

> LayoutTests/ChangeLog:9
> +	   not below the border box. The behavior was correct for flow thread
cases, but not for not flow thread cases. I refactored

nit: "The behavior was correct for flow thread cases, but not for not flow
thread cases." I'm not sure I follow this phrase :)

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1657
> +    if (lineOverFlowsFromShapeInside)

nit: Let's keep the Overflow with small caps, just to be consistent with the
function name.