[webkit-reviews] review granted: [Bug 117390] Introducing StackIterator class. : [Attachment 204831] C++ idiomatic patch as a delta from rolled out patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 117390: Introducing StackIterator class.
https://bugs.webkit.org/show_bug.cgi?id=117390

Attachment 204831: C++ idiomatic patch as a delta from rolled out patch
https://bugs.webkit.org/attachment.cgi?id=204831&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204831&action=review


r=me, but please fix the missing end() check before landing.

> Source/JavaScriptCore/runtime/JSFunction.cpp:208
> +    StackIterator iter = exec->find(functionObj, skipOverBoundFunctions);
>      ++iter;

I think we need an end() check here: functionObj may not be on the stack.