[webkit-reviews] review denied: [Bug 106620] [EFL] Add support for MHTML save/load feature to MiniBrowser : [Attachment 204782] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has denied Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 106620: [EFL] Add support for MHTML save/load feature to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=106620

Attachment 204782: Patch
https://bugs.webkit.org/attachment.cgi?id=204782&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204782&action=review


>> Tools/ChangeLog:9
>> +	    from filesystem
> 
> Add a new line.

and period.

> Tools/MiniBrowser/efl/main.c:441
> +	   char *save_file_name = show_file_entry_dialog(window);

never freed?

> Tools/MiniBrowser/efl/main.c:450
> +	   Eina_Strbuf *uri_path = eina_strbuf_new();

never freed?

> Tools/MiniBrowser/efl/main.c:452
> +	   info("Load page (Ctrl + l) was pressed. Loading  %s \n",
eina_strbuf_string_get(uri_path));

extra space before \n and before %s

> Tools/MiniBrowser/efl/main.c:1021
> +    const char *file_path = ok ?
eina_stringshare_add(elm_fileselector_entry_path_get(fs_entry)) : NULL;

already a stringshare so eina_stringshare_ref() would suffice