[webkit-reviews] review denied: [Bug 117649] [GTK][WK2] adding subtitles (with toggle button) on html videos : [Attachment 204729] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Danilo Cesar Lemes de
Paula <danilo.cesar at collabora.co.uk>'s request for review:
Bug 117649: [GTK][WK2] adding subtitles (with toggle button) on html videos
https://bugs.webkit.org/show_bug.cgi?id=117649

Attachment 204729: Patch
https://bugs.webkit.org/attachment.cgi?id=204729&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204729&action=review


Thanks for the patch.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1163
> +    settings->priv->preferences->setShouldDisplaySubtitles(TRUE);

It should be true, not TRUE. If we want to enable this unconditionally, this is
not the place to do it. You should change the default value of the setting for
the GTK platform in Shared/WebPreferencesStore.h