[webkit-reviews] review granted: [Bug 117386] JSString should remember AtomicString : [Attachment 204178] Fixed the roping issue

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 117386: JSString should remember AtomicString
https://bugs.webkit.org/show_bug.cgi?id=117386

Attachment 204178: Fixed the roping issue
https://bugs.webkit.org/attachment.cgi?id=204178&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204178&action=review


r=me

> Source/JavaScriptCore/runtime/JSString.h:380
> +    if (exec->hadException())
> +	   return nullAtom;

You can move this exception check inside the isRope() block, to tell the
compiler that an exception can only happen if we have to resolve a rope.