[webkit-reviews] review granted: [Bug 116319] webkit-backface-visibility on a parent element stops background-position from updating : [Attachment 204781] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 116319: webkit-backface-visibility on a parent element stops
background-position from updating
https://bugs.webkit.org/show_bug.cgi?id=116319

Attachment 204781: Patch
https://bugs.webkit.org/attachment.cgi?id=204781&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204781&action=review


> Source/WebCore/rendering/RenderObject.h:1255
> +	       if (oldStyle && m_style->diffRequiresRepaint(oldStyle))

Is there some other level of the code already doing a diff? Is it bad for
performance to do this here too?

> Source/WebCore/rendering/style/RenderStyle.cpp:797
> +    unsigned contextSensitiveProperties = 0;

This should be named changedContextSensitiveProperties. Leaving out the word
“changed” makes it hard to understand that this is an out argument and whether
0 is the correct value to initialize to.