[webkit-reviews] review granted: [Bug 65793] Painting of fixed background images is wrong in composited layers : [Attachment 204773] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 15 20:46:17 PDT 2013


Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 65793: Painting of fixed background images is wrong in composited layers
https://bugs.webkit.org/show_bug.cgi?id=65793

Attachment 204773: Patch
https://bugs.webkit.org/attachment.cgi?id=204773&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204773&action=review


> Source/WebCore/rendering/RenderBoxModelObject.cpp:1227
> +    // FIXME: transforms spec says that fixed backgrounds behave like scroll
inside transforms.

Since we have a bug on this, you should add the link.

> Source/WebCore/rendering/RenderBoxModelObject.h:203
> +	   { }

I prefer these on separate lines :(.


More information about the webkit-reviews mailing list