[webkit-reviews] review granted: [Bug 117676] Concurrent JIT shouldn't try to recompute the CodeBlockHash as part of debug dumps, since doing so may fail if dealing with a CachedScript that doesn't have its script string handy : [Attachment 204776] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 117676: Concurrent JIT shouldn't try to recompute the CodeBlockHash as part
of debug dumps, since doing so may fail if dealing with a CachedScript that
doesn't have its script string handy
https://bugs.webkit.org/show_bug.cgi?id=117676

Attachment 204776: Patch
https://bugs.webkit.org/attachment.cgi?id=204776&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204776&action=review


> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1554
> +#if ENABLE(JIT)
> +    , m_capabilityLevelState(DFG::CapabilityLevelNotSet)
> +#endif

Is this related?  If not, you should call it out in your changelog or commit it
separately.