[webkit-reviews] review granted: [Bug 117673] Move Pasteboard::getStringSelection to Editor, fixing a layering violation : [Attachment 204772] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 117673: Move Pasteboard::getStringSelection to Editor, fixing a layering
violation
https://bugs.webkit.org/show_bug.cgi?id=117673

Attachment 204772: Patch
https://bugs.webkit.org/attachment.cgi?id=204772&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204772&action=review


> Source/WebCore/editing/mac/EditorMac.mm:278
> +// FIXME: Makes no sense that selectedTextForClipboard always includes alt
text, but stringSelectionForPasteboard does not.
> +// This was left in a bad state when selectedTextForClipboard was added.
Need to look over clients and fix this.

There is some discussion in https://bugs.webkit.org/show_bug.cgi?id=11200 but
the idea is that we don't want to include alt text when we're exposing it to
Mac services.
I think the one that doesn't include alt should be postfixed with
"ForClipboard".