[webkit-reviews] review denied: [Bug 117669] Web Inspector: Copying array or object output does not contain values : [Attachment 204753] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Antoine Quint
<graouts at apple.com>'s request for review:
Bug 117669: Web Inspector: Copying array or object output does not contain
values
https://bugs.webkit.org/show_bug.cgi?id=117669

Attachment 204753: Patch
https://bugs.webkit.org/attachment.cgi?id=204753&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204753&action=review


> Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js:50
> +    get clipboarPrefixString ()

Typo.

> Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js:659
> +    get clipboarPrefixString ()

Typo.

> Source/WebInspectorUI/UserInterface/LogContentView.js:267
> +	   var usePrefix = messages.length > 1;

I explicitly removed this logic before. I think the prefix is always useful for
row selection and Commad-S. We now support text range selection if you don't
want the prefix.