[webkit-reviews] review granted: [Bug 116205] Use SetFilePointer instead of SetFilePointerEx in FileSystemWin : [Attachment 201925] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 14 15:36:22 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 116205: Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
https://bugs.webkit.org/show_bug.cgi?id=116205

Attachment 201925: Patch
https://bugs.webkit.org/attachment.cgi?id=201925&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201925&action=review


> Source/WebCore/platform/win/FileSystemWin.cpp:336
> +    if (largeOffset.LowPart == 0xFFFFFFFF && GetLastError() != NO_ERROR)

Can we compare LowPart to INVALID_SET_FILE_POINTER instead?


More information about the webkit-reviews mailing list