[webkit-reviews] review granted: [Bug 117647] WKPageFindStringMatches ignores the kWKFindOptionsBackwards option : [Attachment 204733] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 117647: WKPageFindStringMatches ignores the kWKFindOptionsBackwards option
https://bugs.webkit.org/show_bug.cgi?id=117647

Attachment 204733: Patch
https://bugs.webkit.org/attachment.cgi?id=204733&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204733&action=review


I think the test coverage might still be a bit light. It would be good to
exercise even more edge cases. No specific ideas for that, though.

r=me if you fix the header and thus fix the build

> Source/WebKit2/Shared/API/c/WKFindOptions.h:45
> +const int kWKFindResultNoMatchAfterUserSelection = -1;

Since this is a C header we can’t use:

    const int kWKFindResultNoMatchAfterUserSelection = -1;

We can follow the CoreFoundation style and use an enum for this:

    enum { kWKFindResultNoMatchAfterUserSelection = -1 };

Or we can perhaps use this:

    static const int kWKFindResultNoMatchAfterUserSelection = -1;

This is why the Mac build is failing.