[webkit-reviews] review denied: [Bug 112488] REGRESSION (r145854): Mongolian characters are not upright in vertical writing mode : [Attachment 204687] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 14 13:41:21 PDT 2013


Enrica Casucci <enrica at apple.com> has denied SiqinBilige
<siqinbilige at gmail.com>'s request for review:
Bug 112488: REGRESSION (r145854): Mongolian characters are not upright in
vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=112488

Attachment 204687: Patch
https://bugs.webkit.org/attachment.cgi?id=204687&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
I don't think this is the right approach to the problem.
Mongolian text is rendered with the complex path and the reason why this fails
is because the font has vertical glyphs but this information gets lost when we
get to the point of preparing the glyphs to draw.
This fix will solve the problem only for Mongolian characters but not for all
the other characters for which we should avoid rotation (those included in
shouldAvoidRotation) when rendered with a font that has vertical glyphs for
those characters.


More information about the webkit-reviews mailing list