[webkit-reviews] review granted: [Bug 117645] [Windows] Provide simple <meter> drawing logic for testing : [Attachment 204717] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 117645: [Windows] Provide simple <meter> drawing logic for testing
https://bugs.webkit.org/show_bug.cgi?id=117645

Attachment 204717: Patch
https://bugs.webkit.org/attachment.cgi?id=204717&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204717&action=review


> Source/WebCore/rendering/RenderThemeSafari.h:145
> +    virtual IntSize meterSizeForBounds(const RenderMeter*, const IntRect&)
const;
> +    virtual bool supportsMeter(ControlPart) const;
> +    virtual void adjustMeterStyle(StyleResolver*, RenderStyle*, Element*)
const;
> +    virtual bool paintMeter(RenderObject*, const PaintInfo&, const
IntRect&);

No OVERRIDEs on these?

> Source/WebCore/rendering/RenderThemeWin.cpp:140
> +// Progress bar parts
> +#define PP_BAR	   1
> +#define PP_BARVERT	   2
> +#define PP_CHUNK	   3
> +#define PP_CHUNKVERT    4
> +#define PP_FILL	   5
> +#define PP_FILLVERT	   6
> +#define PP_PULSEOVERLAY 7
> +#define PP_MOVEOVERLAY  8
> +#define PP_PULSEOVERLAYVERT 9
> +#define PP_MOVEOVERLAYVERT  10
> +#define PP_TRANSPARENTBAR   11
> +#define PP_TRANSPARENTBARVERT 12
> +
> +// Progress bar states
> +#define PBBS_NORMAL	   1
> +#define PBBS_PARTIAL    2
> +#define PBBVS_NORMAL    1 // Vertical
> +#define PBBVS_PARTIAL   2
> +
> +// Progress bar fill states
> +#define PBFS_NORMAL	   1
> +#define PBFS_ERROR	   2
> +#define PBFS_PAUSED	   3
> +#define PBFS_PARTIAL    4
> +#define PBFVS_NORMAL    1 // Vertical
> +#define PBFVS_ERROR	   2
> +#define PBFVS_PAUSED    3
> +#define PBFVS_PARTIAL   4

I'd use enums for these, but #defines are fine (especially if they come from
Windows headers).