[webkit-reviews] review denied: [Bug 116215] background-color and text-decoration are not preserved when merging paragraphs : [Attachment 204705] passing EditingPropertiesToInclude to removeAllButEditingProperties()

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 116215: background-color and text-decoration are not preserved when merging
paragraphs
https://bugs.webkit.org/show_bug.cgi?id=116215

Attachment 204705: passing EditingPropertiesToInclude to
removeAllButEditingProperties()
https://bugs.webkit.org/attachment.cgi?id=204705&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204705&action=review


Generally looks OK. Would be nice to have more than just the single test.

> Source/WebCore/ChangeLog:22
> +	   Reverse logic to be used after casting PropertiesToInlcude to
EditingPropertiesToInclude.

Typo "Inlcude" occurs many times in this change log.

> Source/WebCore/ChangeLog:38
> +	   Reorder PropertiesToInlcude values to match
EditingPropertiesToInclude to easy cast it.

This is a bad design pattern. We don’t want subtle relationships between
different enums.

> Source/WebCore/editing/EditingStyle.cpp:975
> +   
styleFromRules->removeAllButEditingProperties(static_cast<EditingPropertiesToIn
clude>(propertiesToInclude));

How can this cast be correct? One enum has 3 values and the other has 2. Either
this won’t do the right thing if propertiesToInclude is AllProperties, or it
does the right thing for a strange reason.