[webkit-reviews] review granted: [Bug 90272] <video> element delays document load event for ~ 3 seconds : [Attachment 204669] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 90272: <video> element delays document load event for ~ 3 seconds
https://bugs.webkit.org/show_bug.cgi?id=90272

Attachment 204669: Patch
https://bugs.webkit.org/attachment.cgi?id=204669&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204669&action=review


> Source/WebCore/ChangeLog:11
> +	   (WebCore::HTMLMediaElement::prepareForLoad):

Nit: I think it is useful to have per-method comments so it is easier to
understand what changed when reading the ChangeLog later.

> LayoutTests/media/media-preload-no-delay-loadevent.html:8
> +	   testRunner.waitUntilDone();

Nit: double indent

> LayoutTests/media/media-preload-no-delay-loadevent.html:37
> +    var source = document.getElementById('source');
> +    source.src = findMediaFile("video", "content/test.mp4");

Nit: there is no need to use a <source> element when only one media url is
used.