[webkit-reviews] review granted: [Bug 117585] Context menu grammar checking items are available when GRAMMAR_CHECKING macro is off : [Attachment 204560] guard grammar checking in context menu code

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 117585: Context menu grammar checking items are available when
GRAMMAR_CHECKING macro is off
https://bugs.webkit.org/show_bug.cgi?id=117585

Attachment 204560: guard grammar checking in context menu code
https://bugs.webkit.org/attachment.cgi?id=204560&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204560&action=review


> Source/WebCore/platform/LocalizedStrings.cpp:304
>      if (show)
> +#if USE(GRAMMAR_CHECKING)
>	   return WEB_UI_STRING("Show Spelling and Grammar", "menu item
title");
>      return WEB_UI_STRING("Hide Spelling and Grammar", "menu item title");
> +#else
> +	   return WEB_UI_STRING("Show Spelling", "menu item title");
> +    return WEB_UI_STRING("Hide Spelling", "menu item title");
> +#endif

I'd rather if (show) was duplicated here, once in the #if block and once in the
#else block.