[webkit-reviews] review granted: [Bug 117620] Clicking on snapshotting plug-ins does not restart them : [Attachment 204658] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 13 18:19:37 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 117620: Clicking on snapshotting plug-ins does not restart them
https://bugs.webkit.org/show_bug.cgi?id=117620

Attachment 204658: Patch
https://bugs.webkit.org/attachment.cgi?id=204658&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204658&action=review


> Source/WebCore/html/HTMLPlugInImageElement.cpp:716
> +	   if (displayState() == WaitingForSnapshot && event->type() ==
eventNames().clickEvent && isPlugInImageElement()) {

I think this would be slightly clearer if you did the event->type() last.


More information about the webkit-reviews mailing list