[webkit-reviews] review granted: [Bug 117562] Headers and footers should be pinned to the left edge of the window when scrolling horizontally, even when zoomed : [Attachment 204540] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Beth Dakin <bdakin at apple.com>'s request
for review:
Bug 117562: Headers and footers should be pinned to the left edge of the window
when scrolling horizontally, even when zoomed
https://bugs.webkit.org/show_bug.cgi?id=117562

Attachment 204540: Patch
https://bugs.webkit.org/attachment.cgi?id=204540&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204540&action=review


> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:321
> +    float horizontalScrollOffsetForBanner =
scrollOffsetForFixedChildren.width();
> +    if (frameScaleFactor() != 1)
> +	   horizontalScrollOffsetForBanner =
FrameView::scrollOffsetForFixedPosition(viewportRect(), totalContentsSize(),
position, scrollOrigin(), 1, false, headerHeight(), footerHeight()).width();
> +

This could use a comment.  It is confusing enough.