[webkit-reviews] review granted: [Bug 117597] Add support for AVFoundation-backed HTMLMediaElements in the WebVideoFullScreenController. : [Attachment 204623] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 117597: Add support for AVFoundation-backed HTMLMediaElements in the
WebVideoFullScreenController.
https://bugs.webkit.org/show_bug.cgi?id=117597

Attachment 204623: Patch
https://bugs.webkit.org/attachment.cgi?id=204623&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204623&action=review


Nice rework!

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:102
> +- (void)setupVideoOverlay:(CALayer*)layer

Nit: you should have a space before the "*"

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:146
> +	       QTMovie* movie = _mediaElement->platformMedia().media.qtMovie;
> +	       QTMovieLayer* layer = [[getQTMovieLayerClass() alloc] init];

Nit: ObjC types get the "*" next to the variable name.

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:159
> +	       AVPlayer* player =
_mediaElement->platformMedia().media.avfMediaPlayer;
> +	       AVPlayerLayer* layer = [[getAVPlayerLayerClass() alloc] init];

Ditto.

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:194
> +    CALayer* layer = [[[self window] contentView] layer];

Ditto.

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:433
>  // MARK: -
>  // MARK: QTMovie callbacks
>  

Nit: you might want to move this below rateChanged: since it is no longer
QTKit-specific.