[webkit-reviews] review denied: [Bug 100379] [Win] WebView didReceiveIcon delegate call doesn't have the icon in it : [Attachment 171249] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied peavo at outlook.com's request for
review:
Bug 100379: [Win] WebView didReceiveIcon delegate call doesn't have the icon in
it
https://bugs.webkit.org/show_bug.cgi?id=100379

Attachment 171249: Patch
https://bugs.webkit.org/attachment.cgi?id=171249&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171249&action=review


Looks good.  I think it would be simpler to create one IntSize and use it in
both API calls that need it.  Can you make that small change and I'll r+ this?

> Source/WebKit/win/WebView.cpp:2842
> +	   sz.cy = 16;

Why not just create the IntSize directly, then use it later?

> Source/WebKit/win/WebView.cpp:2844
> +	   BitmapInfo bmInfo = BitmapInfo::create(IntSize(sz));

Use the IntSize here...

> Source/WebKit/win/WebView.cpp:2848
> +	   Image* icon = iconDatabase().synchronousIconForPageURL(str,
IntSize(sz));

... and here!