[webkit-reviews] review denied: [Bug 117342] [curl] Merge http response header values : [Attachment 204580] style fixed patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Peter Gal
<galpeter at inf.u-szeged.hu>'s request for review:
Bug 117342: [curl] Merge http response header values
https://bugs.webkit.org/show_bug.cgi?id=117342

Attachment 204580: style fixed patch
https://bugs.webkit.org/attachment.cgi?id=204580&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204580&action=review


Looks great!  I had a couple of minor suggestions.  If you can clarify that
comment I will be happy to approve the patch.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:241
> +    static const char *appendableHeaders[] = {

This should be "static const char*"  The fact that this is a "const char
pointer" is part of the type.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:270
> +    // Custom headers usually starts with 'X-', allow them.

"starts" should be "start" (syntax).

If they usually start with "X-", why do we test with "x-" (case insensitive)? 
Do they usually start with either "X-" or "x-" and we are handling this case
and exiting early?

Maybe the comments should be "Custom headers start with 'X-', and need no
further checking.