[webkit-reviews] review denied: [Bug 90272] <video> element delays document load event for ~ 3 seconds : [Attachment 204573] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 90272: <video> element delays document load event for ~ 3 seconds
https://bugs.webkit.org/show_bug.cgi?id=90272

Attachment 204573: Patch
https://bugs.webkit.org/attachment.cgi?id=204573&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204573&action=review


> LayoutTests/media/media-preload-no-delay-loadevent.html:8
> +function finish(){

Nit: a function's opening brace should be on a new line.

> LayoutTests/media/media-preload-no-delay-loadevent.html:12
> +		}

Eek, a tab!

> LayoutTests/media/media-preload-no-delay-loadevent.html:22
> +		document.getElementById('load-time').innerHTML = loadTime + ' 
PASS';

Logging the time it takes to load will make this test flakey because not all
bots run at the same speed.

> LayoutTests/media/media-preload-no-delay-loadevent.html:30
> +	<source src="void.mp4">

This test should use a valid media file that can be loaded by the platform
being tested. See how other tests use "findMediaFile" to choose a platform
appropriate test file.