[webkit-reviews] review denied: [Bug 117223] [CSS Blending] Updating the -webkit-background-blend-mode property dynamically does not trigger a redraw of the element : [Attachment 204554] Patch for review

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Mihai Tica <mitica at adobe.com>'s
request for review:
Bug 117223: [CSS Blending] Updating the -webkit-background-blend-mode property
dynamically does not trigger a redraw of the element
https://bugs.webkit.org/show_bug.cgi?id=117223

Attachment 204554: Patch for review
https://bugs.webkit.org/attachment.cgi?id=204554&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204554&action=review


>
LayoutTests/css3/compositing/background-blend-mode-image-color-dynamic.html:29
> +	   for (var i = 0; i < blendModes.length; ++i) {
> +	       var elem = document.createElement('div');
> +	       document.body.appendChild(elem);
> +	   }

Are you sure that this test really does the job of testing repaint? I would use
the repaint logic from DRT and have a pixel result of the changed area. Then
you don't need to test all blend modes, but just if the drawn content changed
at all. We already have test to verify that the property value changed. You
should find real repaint tests all over the place.