[webkit-reviews] review requested: [Bug 117547] Support byte and octet types in bindings generators : [Attachment 204584] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 13 07:25:36 PDT 2013


Christophe Dumez <dchris at gmail.com> has asked  for review:
Bug 117547: Support byte and octet types in bindings generators
https://bugs.webkit.org/show_bug.cgi?id=117547

Attachment 204584: Patch
https://bugs.webkit.org/attachment.cgi?id=204584&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
I have improved the fast code path for the toInt8 / toUInt8 methods:
- Use asInt32() / asUInt32() instead of toInt32() / toUInt32() to avoid double
isInt32() / isUInt32() check.
- Handle cases where the value is an integer but not in the range to avoid
falling back to the slow path and convert to a number again

I have also exported the symbols for mac.

Would you mind taking another look please?


More information about the webkit-reviews mailing list