[webkit-reviews] review denied: [Bug 116042] [GStreamer] [texmap] upload a video buffer into the video texture : [Attachment 204424] Patch

[bugzilla-daemon at webkit.org]

Sebastian Dröge <slomo at circular-chaos.org> has denied  review:
Bug 116042: [GStreamer] [texmap] upload a video buffer into the video texture
https://bugs.webkit.org/show_bug.cgi?id=116042

Attachment 204424: Patch
https://bugs.webkit.org/attachment.cgi?id=204424&action=review

------- Additional Comments from Sebastian Dröge <slomo at circular-chaos.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204424&action=review


>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
353
> +	       if (gst_video_gl_texture_upload_meta_upload(meta, ids)) {

This looks all good

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:44
> +#define GST_SURFACE_CAPS "video/x-surface, opengl=true; "

Erm... no. There should not be any video/x-surface caps in 1.0 anywhere. Maybe
you mean "video/x-raw(meta:GstVideoGLTextureMapper)" here?