[webkit-reviews] review denied: [Bug 117547] Support byte and octet types in bindings generators : [Attachment 204452] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 117547: Support byte and octet types in bindings generators
https://bugs.webkit.org/show_bug.cgi?id=117547

Attachment 204452: Patch
https://bugs.webkit.org/attachment.cgi?id=204452&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
I think you need to implement toInt8() and toUInt8() to JSDOMBinding.h. It
would be wrong to use existing toInt32() and toUint32() for the "byte" and
"octet" conversions.

Also I'd like to see test cases (e.g. what happens when we pass -1, 0, 1, 127,
128, 255, 256, null, "foo" etc).