[webkit-reviews] review granted: [Bug 117561] [Windows] Implement Accessibility2 APIs in Windows : [Attachment 204541] Revised to not use global constructors.

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 117561: [Windows] Implement Accessibility2 APIs in Windows
https://bugs.webkit.org/show_bug.cgi?id=117561

Attachment 204541: Revised to not use global constructors.
https://bugs.webkit.org/attachment.cgi?id=204541&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204541&action=review


> Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp:170
> +static const _bstr_t& titleUIElementAttributeKey()
> +{
> +    static const _bstr_t
titleUIElementAttributeKey(L"AXTitleUIElementAttribute");
> +    return titleUIElementAttributeKey;
> +}

This will create a global destructor. I think it’s fine to recreate the string
every time.