[webkit-reviews] review granted: [Bug 117566] [CSS Regions] -webkit-background-clip: text; does not clip the background in regions : [Attachment 204544] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 12 16:28:46 PDT 2013
Alexandru Chiculita <achicu at adobe.com> has granted Max Vujovic
<mvujovic at adobe.com>'s request for review:
Bug 117566: [CSS Regions] -webkit-background-clip: text; does not clip the
background in regions
https://bugs.webkit.org/show_bug.cgi?id=117566
Attachment 204544: Patch
https://bugs.webkit.org/attachment.cgi?id=204544&action=review
------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204544&action=review
r=me
> Source/WebCore/rendering/RenderFlowThread.cpp:306
> + PaintBehavior paintBehavior = 0;
nit: I know that you are going to do selection phase, too. Usually we would
have written this in one single line using the ?: operator.
More information about the webkit-reviews
mailing list