[webkit-reviews] review granted: [Bug 117385] fourthTier: DFG should support op_in and it should use patching to make it fast : [Attachment 204376] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 12 13:18:16 PDT 2013


Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 117385: fourthTier: DFG should support op_in and it should use patching to
make it fast
https://bugs.webkit.org/show_bug.cgi?id=117385

Attachment 204376: the patch
https://bugs.webkit.org/attachment.cgi?id=204376&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Would be nice to take even more advantage and further optimize for cases like

    if (!("property" in object))
	throw "oops!";
    return object.property;

but I can't in good conscience thumb my nose at a 17X speedup.


More information about the webkit-reviews mailing list