[webkit-reviews] review granted: [Bug 116745] [CSS Shapes] rectangle and inset-rectangle do not properly handle rx and ry : [Attachment 204454] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 116745: [CSS Shapes] rectangle and inset-rectangle do not properly handle
rx and ry
https://bugs.webkit.org/show_bug.cgi?id=116745

Attachment 204454: Patch
https://bugs.webkit.org/attachment.cgi?id=204454&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204454&action=review


r=me but please add the assertions to be sure.

> Source/WebCore/css/BasicShapeFunctions.cpp:-53
> -	   if (!rectangle->cornerRadiusX().isUndefined()) {

Was skeptical about about removing this if clause. Bem wants to add an ASSERT,
since he says it can never be undefined. He should be right, since we always
set the value on style resolving.

> Source/WebCore/css/BasicShapeFunctions.cpp:-105
> -	   if (!rectangle->cornerRadiusX().isUndefined()) {

Ditto.