[webkit-reviews] review granted: [Bug 117451] [BlackBerry] Smarter algorithm to determine the backingstore rect : [Attachment 204231] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Jakob Petsovits
<jpetsovits at blackberry.com>'s request for review:
Bug 117451: [BlackBerry] Smarter algorithm to determine the backingstore rect
https://bugs.webkit.org/show_bug.cgi?id=117451

Attachment 204231: Patch
https://bugs.webkit.org/attachment.cgi?id=204231&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204231&action=review


Looks good, please think about the more verbose naming before landing.

>> Source/WebKit/blackberry/Api/BackingStore.cpp:855
>> +	    const float l = expandLeft;
> 
> l is incorrectly named. Don't use the single letter 'l' as an identifier
name.  [readability/naming] [4]

More verbose would be better but up to you.