[webkit-reviews] review denied: [Bug 117522] Make sure we aren't throttling plugin timers during initialisation and destruction : [Attachment 204362] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Oliver Hunt <oliver at apple.com>'s request
for review:
Bug 117522: Make sure we aren't throttling plugin timers during initialisation
and destruction
https://bugs.webkit.org/show_bug.cgi?id=117522

Attachment 204362: Patch
https://bugs.webkit.org/attachment.cgi?id=204362&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204362&action=review


> Source/WebKit2/Shared/ActivityAssertion.cpp:28
> +#include "config.h"
> +
> +#include "ActivityAssertion.h"

You should not have newline here.

> Source/WebKit2/Shared/ActivityAssertion.h:36
> +class ChildProcess;
> +class ActivityAssertion {

You should have a newline here.

> Source/WebKit2/Shared/ActivityAssertion.h:39
> +    WTF_MAKE_NONCOPYABLE(ActivityAssertion);
> +
> +public:

You should not have a newline here.

> Source/WebKit2/Shared/ActivityAssertion.h:43
> +    static PassOwnPtr<ActivityAssertion> create(ChildProcess* process)
> +    {
> +	   return adoptPtr(new ActivityAssertion(process));
> +    }

If this is only ever used on the stack, is there any reason to make this use
OwnPtr/PassOwnPtr?

> Source/WebKit2/Shared/ActivityAssertion.h:50
> +    ActivityAssertion(ChildProcess*);
> +    ChildProcess* m_process;
> +};

You should have a newline here.

> Source/WebKit2/Shared/ChildProcess.h:82
> +    PassOwnPtr<ActivityAssertion> takeActivityAssertion()
> +    {
> +	   return ActivityAssertion::create(this);
> +    }
> +    
> +

Extra newline.