[webkit-reviews] review requested: [Bug 116873] [Qt][WK2] Make the work queue take the ownership of the socket descriptor : [Attachment 204370] Patch

[bugzilla-daemon at webkit.org]

Lamarque V. Souza <Lamarque.Souza at basyskom.com> has asked  for review:
Bug 116873: [Qt][WK2] Make the work queue take the ownership of the socket
descriptor
https://bugs.webkit.org/show_bug.cgi?id=116873

Attachment 204370: Patch
https://bugs.webkit.org/attachment.cgi?id=204370&action=review

------- Additional Comments from Lamarque V. Souza
<Lamarque.Souza at basyskom.com>
Proposed patch. By what I can see only Connection::platformInitialize() closes
the socket descriptor in the Qt port. This patch moves the loop closing the
socket descriptor to SocketNotifier's destructor. SocketNotifier is a new class
that inherits from QSocketNotifier. SocketNotifier is destroyed a few lines
below the loop in Connection::platformInvalidate(), so this change should keep
things working the same as before. I tested this change with the 'Test case'
patch in https://bugs.webkit.org/show_bug.cgi?id=115880 and it passes.