[webkit-reviews] review denied: [Bug 18305] Border drawing incorrect when using both border-collapse: collapse and overflow: hidden on a table : [Attachment 204187] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 18305: Border drawing incorrect when using both border-collapse: collapse
and overflow: hidden on a table
https://bugs.webkit.org/show_bug.cgi?id=18305

Attachment 204187: Patch
https://bugs.webkit.org/attachment.cgi?id=204187&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204187&action=review


r-

> Source/WebCore/rendering/RenderTable.cpp:1364
> +    LayoutRect rect;
> +    if (phase == PaintPhaseChildBlockBackgrounds) {
> +	   rect = borderBoxRectInRegion(region);
> +	   rect.setLocation(location + rect.location());
> +    } else
> +	   rect = RenderBox::overflowClipRect(location, region, relevancy);

I just don't think you can make this phase-dependent. Make the table into a
self-painting layer, e.g., by making it position:absolute, and suddenly the
overflowClipRect is going to get cached by the RenderLayer clipRects code, and
it's not going to use the phase you want.

Basically overflowClipRect can't be giving different answers based off phases.