[webkit-reviews] review granted: [Bug 117513] [Windows] Implement 'attributeValue' accessor to support test infrastructure : [Attachment 204348] Revised to get rid of horrid Visual Studio project cruft.

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 117513: [Windows] Implement 'attributeValue' accessor to support test
infrastructure
https://bugs.webkit.org/show_bug.cgi?id=117513

Attachment 204348: Revised to get rid of horrid Visual Studio project cruft.
https://bugs.webkit.org/attachment.cgi?id=204348&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204348&action=review


> Source/WebKit/win/AccessibleBase.cpp:849
> +    *value = ::SysAllocStringLen(reinterpret_cast<const
wchar_t*>(valueAtomic.characters()), valueAtomic.length());

This could use a BString together with .release().

> Tools/DumpRenderTree/win/AccessibilityControllerWin.cpp:88
> +    COMPtr<IAccessibleComparable>comparable =
comparableObject(serviceProvider);

Missing space.

> Tools/DumpRenderTree/win/AccessibilityControllerWin.cpp:107
> +

No need for a newline here.

> Tools/DumpRenderTree/win/AccessibilityControllerWin.cpp:122
> +    BSTR idAttribute = JSStringCopyBSTR(id);

I think you can use a BString here - just use BString::adopt. (or better yet,
add an adoptBString function just like we have for RetainPtr).