[webkit-reviews] review denied: [Bug 114268] [CSS Regions] Regions don't create a stacking context for their contents : [Attachment 204343] Patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has denied Max Vujovic
<mvujovic at adobe.com>'s request for review:
Bug 114268: [CSS Regions] Regions don't create a stacking context for their
contents
https://bugs.webkit.org/show_bug.cgi?id=114268

Attachment 204343: Patch
https://bugs.webkit.org/attachment.cgi?id=204343&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204343&action=review


> Source/WebCore/rendering/RenderRegion.cpp:166
> +    bool isPaintingBackground = (paintInfo.phase ==
PaintPhaseBlockBackground || paintInfo.phase ==
PaintPhaseChildBlockBackground);
> +    if (!isValid() || (!isPaintingBackground && paintInfo.phase !=
PaintPhaseSelection))

Let's extract this into something like "bool shouldPaint". It looks bad with so
many negations in it.