[webkit-reviews] review granted: [Bug 117486] Split SelectorDataList::executeSingleTagNameSelectorData() into the 4 kinds of traversal : [Attachment 204285] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 117486: Split SelectorDataList::executeSingleTagNameSelectorData() into the
4 kinds of traversal
https://bugs.webkit.org/show_bug.cgi?id=117486

Attachment 204285: Patch
https://bugs.webkit.org/attachment.cgi?id=204285&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204285&action=review


r=me provided the following comments are addressed.

> Source/WebCore/dom/SelectorQuery.cpp:161
> +	   if (element->localName() == localName) {

Can we assert that this condition matches with
SelectorChecker::tagMatches(element, tagQualifiedName)?
I'm afraid that this might get out of sync with SelectorChecker::tagMatches
some day.

> Source/WebCore/dom/SelectorQuery.cpp:173
> +	   matchedElements.append(element);

Ditto.