[webkit-reviews] review granted: [Bug 117220] Allow for toggling fullscreen on <video> elements : [Attachment 204168] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Ruth Fong <ruthiecftg at gmail.com>'s
request for review:
Bug 117220: Allow for toggling fullscreen on <video> elements
https://bugs.webkit.org/show_bug.cgi?id=117220

Attachment 204168: Patch
https://bugs.webkit.org/attachment.cgi?id=204168&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204168&action=review


> Source/WebCore/page/ContextMenuController.cpp:1366
> +	   case ContextMenuItemTagToggleVideoFullscreen:
> +#if SUPPORTS_TOGGLE_VIDEO_FULLSCREEN
> +		   if (!m_hitTestResult.mediaIsInFullscreen())
> +		       item.setTitle(contextMenuItemTagEnterVideoFullscreen());

> +		   else 
> +		       item.setTitle(contextMenuItemTagExitVideoFullscreen());
> +		   break;
> +#endif

Nit: indent here is one level too many.

Also, I suggest rewriting this as
item.setTitle(m_hitTestResult.mediaIsInFullscreen() ? contextMen...)