[webkit-reviews] review granted: [Bug 117395] [CSSRegions] ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result) in RenderGeometryMap::mapToContainer : [Attachment 204150] Patch 2

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 117395: [CSSRegions] ASSERTION FAILED:
roundedIntPoint(rendererMappedResult) == roundedIntPoint(result) in
RenderGeometryMap::mapToContainer
https://bugs.webkit.org/show_bug.cgi?id=117395

Attachment 204150: Patch 2
https://bugs.webkit.org/attachment.cgi?id=204150&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204150&action=review


r=me, but we should also add a bug to fix the initial assert when proper
compositing is implemented.

> LayoutTests/fast/regions/assert-flow-thread-compositing.html:5
> +	       .transformed { width: 50px; height: 50px; background-color:
salmon; -webkit-transform: translateZ(0px); border: 1px solid black; }

nit: just use green instead of salmon :)

> Source/WebCore/rendering/RenderLayerCompositor.cpp:926
> +	   layer->setHasCompositingDescendant(false);

nit: I think you don't need this, it's false by default. We are going to fix it
for 84900 anyway.