[webkit-reviews] review requested: [Bug 117390] Introducing StackIterator class. : [Attachment 204136] the patch.

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 117390: Introducing StackIterator class.
https://bugs.webkit.org/show_bug.cgi?id=117390

Attachment 204136: the patch.
https://bugs.webkit.org/attachment.cgi?id=204136&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204136&action=review


> Source/JavaScriptCore/interpreter/StackIterator.cpp:308
> +    // this -> The callee; this is either an inlined callee in which case it
already has
> +    //    a pointer to the true caller. Otherwise it contains current PC in
the machine
> +    //    caller.
> +    //
> +    // machineCaller -> The caller according to the machine, which may be
zero or
> +    //    more frames above the true caller due to inlining.

The above comments are stale, and came from CallFrame::trueCallerFrame().  I'll
remove them.

> Source/JavaScriptCore/profiler/ProfileNode.h:133
> +	   typedef Vector<RefPtr<ProfileNode> >::const_iterator StackIterator;

I made this private to avoid a name conflict with the new StackIterator class.